linux-kernel - [PATCH 2/2] block: skd_main: Reduce dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Aug 2016 19:16:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] block: skd_main: Reduce dynamic_debug size

Delete __func__ and __LINE__ from skd_dbg.

skd_main does not enable DEBUG so these skd_dbg/pr_debug uses
are not enabled unless dynamic_debug is enabled.

dynamic_debug can optionally emit __func__ and __LINE__ so the
default use of %s:%d is not necessary.

$ size drivers/block/skd_main.o*
   text	   data	    bss	    dec	    hex	filename
  48566	  14148	     12	  62726	   f506	drivers/block/skd_main.o.dynamic_debug.new
  52341	  14148	     12	  66501	  103c5	drivers/block/skd_main.o.dynamic_debug.old

Signed-off-by: Joe Perches <joe@...ches.com>
---
 drivers/block/skd_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 3cd3dcc..1d8e1d8 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -88,8 +88,7 @@ MODULE_VERSION(DRV_VERSION "-" DRV_BUILD_ID);
 
 /* debugging macro */
 #define skd_dbg(skdev, fmt, ...)					\
-	pr_debug("%s:%s:%d " fmt,					\
-		 (skdev)->name, __func__, __LINE__, ##__VA_ARGS__)
+	pr_debug("%s: " fmt, (skdev)->name, ##__VA_ARGS__)
 
 #define PCI_VENDOR_ID_STEC      0x1B39
 #define PCI_DEVICE_ID_S1120     0x0001
-- 
2.8.0.rc4.16.g56331f8