linux-kernel - RE: [PATCH V1] mfd: da9053: ensure the FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173DD07A3@SW-EX-MBX02.diasemi.com>
Date:	Mon, 15 Aug 2016 12:37:01 +0000
From:	Steve Twiss <stwiss.opensource@...semi.com>
To:	'Lee Jones' <lee.jones@...aro.org>
CC:	'LINUXKERNEL' <linux-kernel@...r.kernel.org>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH V1] mfd: da9053: ensure the FAULT_LOG is cleared during
 MFD driver probe

> On 08 August 2016 12:06, Steve Twiss wrote:
> > On 05 August 2016 10:05, Lee Jones wrote:
> > > On Wed, 06 Jul 2016, Steve Twiss wrote:
> > > > From: Steve Twiss <stwiss.opensource@...semi.com>
> > > >
> > > > Clearance of any the persistent information within the DA9053 FAULT_LOG
> > > > register must be completed during start-up so the fault-log does not
> > > > continue with previous values. A clearance function has been added here in
> > > > the kernel driver because wiping the fault-log cannot be counted on outside
> > > > the Linux kernel.
> >
> > [...]
> >
> > >
> > > Looks like much of the same code.  Can you have a pop at generifying
> > > this to avoid any unnecessary duplication?
> >
> > Hi Lee,
> >
> > Although the function looks like those found in both the DA9062 and DA9063 drivers, I was just
> > intending to highlight the "requirement similarities" to clear the fault register on start-up. This
> > requirement for the Dialog PMIC chips extends across those devices, but the function is not
> > really general enough to be merged into the kernel core or reused across other Dialog devices.
> >
> > I don't think there is unnecessary duplication in this particular case for the DA9052/53 driver.
> >
> > This da9052_clear_fault_log() function will apply to both the Dialog DA9052 and DA9053 PMICs
> > and so I am making good use of code re-use in this place. But, this does not extend to the
> > DA9062 or DA9063.
> >
> > I don't think this FAULT_LOG clearance function in this case is really open to generalisation past
> > the DA9052/53 driver.
> 
> Hi Lee,
> 
[...]
> The fault log function is individual for each chip and would be customisable to meet the needs
> of the customer's target platform.
> 
> The function is meant to be individual. This allows for multiple chips in the same platform -- each
> fault log function could be cleared slightly differently in that case.
[...]

Hi Lee,
Do you have any further thoughts on this topic?
Regards,
Steve