lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Aug 2016 10:27:49 +0530 From: Amitoj Kaur Chawla <amitoj1606@...il.com> To: thierry.reding@...il.com, airlied@...ux.ie, swarren@...dotorg.org, gnurou@...il.com, dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org Cc: julia.lawall@...6.fr Subject: [PATCH v2] drm/tegra: dpaux: Modify error handling devm_pinctrl_register returns an ERR_PTR in case of error and should have an IS_ERR check instead of a null check. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = devm_pinctrl_register(...); if( - !e + IS_ERR(e) ) { <+... return - ... + PTR_ERR(e) ; ...+> } Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com> --- Changes in v2: -Correct typo drivers/gpu/drm/tegra/dpaux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 059f409..2fde44c 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) dpaux->desc.owner = THIS_MODULE; dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); - if (!dpaux->pinctrl) { + if (IS_ERR(dpaux->pinctrl)) { dev_err(&pdev->dev, "failed to register pincontrol\n"); - return -ENODEV; + return PTR_ERR(dpaux->pinctrl); } #endif /* enable and clear all interrupts */ -- 1.9.1
Powered by blists - more mailing lists