linux-kernel - Re: [PATCH] extcon: Introduce EXTCON_PROP_USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Aug 2016 09:55:23 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	linux-kernel@...r.kernel.org, Guenter Roeck <groeck@...omium.org>,
	Chris Zhong <zyw@...k-chips.com>
Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property

Hi Guenter,

Looks good to me.
I'll add the reference[1] information on patch description and applied it.
[1] https://en.wikipedia.org/wiki/USB#Overview

Thanks,
Chanwoo Choi

On 2016년 08월 15일 22:15, Guenter Roeck wrote:
> From: Guenter Roeck <groeck@...omium.org>
> 
> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
> and USB3 connections on USB Type-C cables.
> 
> Cc: Chris Zhong <zyw@...k-chips.com>
> Signed-off-by: Guenter Roeck <groeck@...omium.org>
> ---
> Applies on top of extcon-next.
> 
>  include/linux/extcon.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index ad7a1606a7f3..38d2c0dec2c1 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -107,12 +107,18 @@
>   * @type:	integer (intval)
>   * @value:	0 (normal) or 1 (flip)
>   * @default:	0 (normal)
> + * - EXTCON_PROP_USB_SUPERSPEED
> + * @type:       integer (intval)
> + * @value:      0 (USB/USB2) or 1 (USB3)
> + * @default:    0 (USB/USB2)
> + *
>   */
>  #define EXTCON_PROP_USB_VBUS		0
>  #define EXTCON_PROP_USB_TYPEC_POLARITY	1
> +#define EXTCON_PROP_USB_SUPERSPEED	2
>  
>  #define EXTCON_PROP_USB_MIN		0
> -#define EXTCON_PROP_USB_MAX		1
> +#define EXTCON_PROP_USB_MAX		2
>  #define EXTCON_PROP_USB_CNT	(EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>  
>  /* Properties of EXTCON_TYPE_CHG. */
>