linux-kernel - Re: [PATCH] drm/hisilicon: add back missing } on ade_dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Aug 2016 13:21:50 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Colin King <colin.king@...onical.com>
Cc:	Xinliang Liu <z.liuxinliang@...ilicon.com>,
	Xinwei Kong <kong.kongxinwei@...ilicon.com>,
	Chen Feng <puck.chen@...ilicon.com>,
	David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Eric Engestrom <eric.engestrom@...tec.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/hisilicon: add back missing } on ade_dc_ops

On Wed, Aug 17, 2016 at 12:09:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Fix build error by adding back the closing } on ade_dc_ops which
> got accidentally removed from an earlier commit.
> 
> Fixes: d25bcfb8c2e18b9b36 ("Don't set drm_device->platformdev")

Yeah that patch was horribly screwed up, but at least in my testing
there's more broken with it. Does this really fix it?
-Daniel

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 91188f3..c9f8166 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -1062,4 +1062,4 @@ static void ade_drm_cleanup(struct platform_device *pdev)
>  const struct kirin_dc_ops ade_dc_ops = {
>  	.init = ade_drm_init,
>  	.cleanup = ade_drm_cleanup
> -;
> +};
> -- 
> 2.9.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch