linux-kernel - Re: [PATCH 2/4] usb: host: xhci: Introduce one new 'usb3_slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2016 16:54:55 +0800
From:	Baolin Wang <baolin.wang@...aro.org>
To:	Felipe Balbi <balbi@...nel.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>, mathias.nyman@...el.com,
	USB <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 2/4] usb: host: xhci: Introduce one new
 'usb3_slow_suspend' member for xhci private data

Hi Felipe,

On 18 August 2016 at 15:18, Felipe Balbi <balbi@...nel.org> wrote:
>
> Hi,
>
> Baolin Wang <baolin.wang@...aro.org> writes:
>> Now some usb controllers (such as dwc3 controller) need 'XHCI_SLOW_SUSPEND'
>> quirk when suspending the xhci, thus we need to add 'usb3_slow_suspend' member
>> in xhci platform data to support this.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>> ---
>>  drivers/usb/host/xhci-plat.c     |    3 +++
>>  include/linux/usb/xhci_pdriver.h |    3 +++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>> index e2e2487..162f17c 100644
>> --- a/drivers/usb/host/xhci-plat.c
>> +++ b/drivers/usb/host/xhci-plat.c
>> @@ -250,6 +250,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>                       (pdata && pdata->usb3_lpm_capable))
>>               xhci->quirks |= XHCI_LPM_SUPPORT;
>>
>> +     if (pdata && pdata->usb3_slow_suspend)
>> +             xhci->quirks |= XHCI_SLOW_SUSPEND;
>
> I remember having a discussion about this with Paul Z and it turned out
> that we really didn't need SLOW_SUSPEND. Can you describe further in
> what situation you need this quirk?

On my dwc3 platform, xhci suspend will be failed if we have not
enabled XHCI_SLOW_SUSPEND quirk.


-- 
Baolin.wang
Best Regards