linux-kernel - Re: [PATCH v9 2/2] PCI: Rockchip: Add Rockchip PCIe controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2016 09:20:42 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     shawn.lin@...k-chips.com, Bjorn Helgaas <bhelgaas@...gle.com>,
        Marc Zyngier <marc.zyngier@....com>, linux-pci@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        Heiko Stuebner <heiko@...ech.de>,
        Doug Anderson <dianders@...omium.org>,
        Wenrui Li <wenrui.li@...k-chips.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v9 2/2] PCI: Rockchip: Add Rockchip PCIe controller
 support

在 2016/8/19 5:24, Bjorn Helgaas 写道:
> Hi Shawn,
>
> On Thu, Aug 04, 2016 at 03:52:08PM +0800, Shawn Lin wrote:
>> This patch adds Rockchip PCIe controller support found
>> on RK3399 Soc platform.
>
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -264,4 +264,15 @@ config PCIE_ARTPEC6
>>  	  Say Y here to enable PCIe controller support on Axis ARTPEC-6
>>  	  SoCs.  This PCIe controller uses the DesignWare core.
>>
>> +config PCIE_ROCKCHIP
>> +	bool "Rockchip PCIe controller"
>> +	depends on ARM64 && ARCH_ROCKCHIP
>
> I don't see any actual ARM64 dependencies in the code (which is a very
> good thing!).  Can we remove the "depends on ARM64" part?

sure, we could. Actually we are going to use this controller for
arm32 as well, so yes, I will remove it.

>
>> +	depends on OF
>> +	depends on PCI_MSI_IRQ_DOMAIN
>> +	select MFD_SYSCON
>> +	help
>> +	  Say Y here if you want internal PCI support on Rockchip SoC.
>> +	  There is 1 internal PCIe port available to support GEN2 with
>> +	  4 slots.
>
>
>


-- 
Best Regards
Shawn Lin