linux-kernel - Re: [PATCH] powerpc/8xx: use SPRN_EIE and SPRN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2016 18:52:47 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Segher Boessenkool <segher@...nel.crashing.org>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Scott Wood <oss@...error.net>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/8xx: use SPRN_EIE and SPRN_EID to enable/disable
 interrupts



Le 18/08/2016 à 18:34, Segher Boessenkool a écrit :
> On Thu, Aug 18, 2016 at 05:56:02PM +0200, Christophe Leroy wrote:
>> The 8xx has two special registers called EID (External Interrupt
>> Disable) and EIE (External Interrupt Enable) for clearing/setting
>> EE in MSR. It avoids the three instructions set mfmsr/ori/mtmsr or
>> mfmsr/rlwinm/mtmsr.
>
> All 8xx?  What other models?  (5xx for example).

At least 823, 860, 866 and 885 have it.

Looks like the 5xx have it too (at least the 565). Does Linux supports 
that one at all ?

8272 and 8323 don't have it.

>
>> +/* Special MSR manipulation registers */
>> +#define SPRN_EIE	80	/* External interrupt enable (EE=1, RI=1) */
>> +#define SPRN_EID	81	/* External interrupt disable (EE=0, RI=1) */
>> +#define SPRN_NRI	81	/* Non Recoverable interrupt (EE=0, RI=0) */
>
> This is wrong (NRI is 82).  Don't write code you cannot test / don't submit
> code you haven't tested?  :-)

Oops. You're right, copy/paste failure.
Was tested on an 885. Unfortunatly SPRN_NRI is not used (yet) :-(

Christophe