linux-kernel - Re: [PATCH] fib_trie: Fix the description of pos and bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2016 09:26:36 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Xunlei Pang <xlpang@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Alexander Duyck <alexander.h.duyck@...hat.com>,
        Netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fib_trie: Fix the description of pos and bits

On Wed, Aug 17, 2016 at 9:33 PM, Xunlei Pang <xlpang@...hat.com> wrote:
> 1) Fix one typo: s/tn/tp/
> 2) Fix the description about the "u" bits.
>
> Signed-off-by: Xunlei Pang <xlpang@...hat.com>
> ---
>  net/ipv4/fib_trie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
> index d07fc07..eb7c5d1 100644
> --- a/net/ipv4/fib_trie.c
> +++ b/net/ipv4/fib_trie.c
> @@ -249,7 +249,7 @@ static inline unsigned long get_index(t_key key, struct key_vector *kv)
>   * index into the parent's child array. That is, they will be used to find
>   * 'n' among tp's children.
>   *
> - * The bits from (n->pos + n->bits) to (tn->pos - 1) - "S" - are skipped bits
> + * The bits from (n->pos + n->bits) to (tp->pos - 1) - "S" - are skipped bits
>   * for the node n.
>   *
>   * All the bits we have seen so far are significant to the node n. The rest
> @@ -258,7 +258,7 @@ static inline unsigned long get_index(t_key key, struct key_vector *kv)
>   * The bits from (n->pos) to (n->pos + n->bits - 1) - "C" - are the index into
>   * n's child array, and will of course be different for each child.
>   *
> - * The rest of the bits, from 0 to (n->pos + n->bits), are completely unknown
> + * The rest of the bits, from 0 to (n->pos -1) - "u" - are completely unknown
>   * at this point.
>   */
>

These comment fixes all look correct.

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>