lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2016 21:44:56 +0200 From: Peter Zijlstra <peterz@...radead.org> To: Jason Low <jason.low2@....com> Cc: Waiman Long <waiman.long@....com>, Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Ding Tianhong <dingtianhong@...wei.com>, Davidlohr Bueso <dave@...olabs.net>, "Paul E. McKenney" <paulmck@...ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Will Deacon <Will.Deacon@....com>, Tim Chen <tim.c.chen@...ux.intel.com>, Imre Deak <imre.deak@...el.com>, jason.low2@...com Subject: Re: [PATCH v5 3/3] locking/mutex: Ensure forward progress of waiter-spinner On Thu, Aug 18, 2016 at 11:04:40AM -0700, Jason Low wrote: > On Thu, 2016-08-18 at 17:58 +0200, Peter Zijlstra wrote: > > On Thu, Aug 11, 2016 at 11:01:27AM -0400, Waiman Long wrote: > > > The following is the updated patch that should fix the build error in > > > non-x86 platform. > > > > > > > This patch was whitespace challenged, but I think I munged it properly. > > > > I've also stuck something based on Jason's patch on top. Please have a > > look at: > > > > https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/?h=locking/core > > Should we convert the flags back to type 'bool'? No, > We're using them as > booleans and we could also leave unneeded space available in case we > ever need to squeeze some more variable(s) in the structure. Because sizeof(bool) is undefined, that then leaves sizeof(struct mutex) and alignof(struct mutex) and its exact layout also undefined. Never use bool in aggregate types. Of course, an actual implementation needs a sizeof(bool) to translate things, but these are defined in the architecture ABI, not in the language. And having struct mutex change depending on whatever an architecture ABI chooses is very bad form.
Powered by blists - more mailing lists