linux-kernel - Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2016 08:41:51 -0700
From:   James Bottomley <jejb@...ux.vnet.ibm.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     Hannes Reinecke <hare@...e.de>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        stable@...r.kernel.org, #@...e.de, v4.5+@...e.de
Subject: Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of
 is_sas_attached

On Wed, 2016-08-17 at 11:46 +0200, Johannes Thumshirn wrote:
> Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether
> we should obtain the SAS address from a scsi device or not. This will
> prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the
> rphy isn't attached to the SAS transport class, like it is with 
> hpsa's logical devices.

For the entire series:

Reviewed-by: James E.J. Bottomley <jejb@...ux.vnet.ibm.com>

> Fixes: 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
> enclosures')
> Cc: stable@...r.kernel.org # v4.5+

Except that we can't tag this for stable because without 1/3 it will
induce a compile failure within stable.  This means you're going to
have to do the stable process manually and submit both patches to
stable and explain the dependency, once they're upstream.

James