linux-kernel - [PATCH] lib/digsig: remove redundant clean out1 when verifying RSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 21 Aug 2016 11:13:15 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Nicolai Stange <nicstange@...il.com>,
        David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>
Subject: [PATCH] lib/digsig: remove redundant clean out1 when verifying RSA

out1 is already set to zero when allocating by kzalloc, so
we could avoid this clean operation again.

Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
---

 lib/digsig.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/digsig.c b/lib/digsig.c
index 55b8b2f..d6a2aa4 100644
--- a/lib/digsig.c
+++ b/lib/digsig.c
@@ -156,7 +156,6 @@ static int digsig_verify_rsa(struct key *key,
 
 	len = mlen;
 	head = len - l;
-	memset(out1, 0, head);
 	memcpy(out1 + head, p, l);
 
 	kfree(p);
-- 
2.3.7