linux-kernel - Re: [PATCH] staging: lustre: llite: don't clean in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Aug 2016 23:38:49 -0400
From:   Oleg Drokin <oleg.drokin@...el.com>
To:     Shawn Lin <shawn.lin@...k-chips.com>
Cc:     Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <lustre-devel@...ts.lustre.org>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: llite: don't clean in_data again

Acked-by: Oleg Drokin <oleg.drokin@...el.com>

On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:

> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
> 
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 50938bd..ec6b7ce 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3251,7 +3251,6 @@ void *ll_iocontrol_register(llioc_callback_t cb, int count, unsigned int *cmd)
> 	if (!in_data)
> 		return NULL;
> 
> -	memset(in_data, 0, sizeof(*in_data));
> 	in_data->iocd_size = size;
> 	in_data->iocd_cb = cb;
> 	in_data->iocd_count = count;
> -- 
> 2.3.7
>