linux-kernel - Re: [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2016 15:52:53 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        edubezval@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-pm@...r.kernel.org, PhucBui <bd-phuc@...so.co.jp>
Subject: Re: [PATCH] thermal: rcar_thermal: don't call
 thermal_zone_device_unregister when USE_OF_THERMAL

On 一, 2016-08-22 at 03:19 +0000, Kuninori Morimoto wrote:
> From: Bui Duc Phuc <bd-phuc@...so.co.jp>
> 
> devm_thermal_zone_of_sensor_register() case doesn't need to call
> thermal_zone_device_unregister().
> Otherwise, rcar-thermal can't register thermal zone again after
> rebind.
> This patch fixes it.
> 
> Signed-off-by: Bui Duc Phuc <bd-phuc@...so.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Patch applied.

thanks,
rui
> ---
>  drivers/thermal/rcar_thermal.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 4d07644..b5c6442 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -419,9 +419,10 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
>  
>  	rcar_thermal_for_each_priv(priv, common) {
>  		rcar_thermal_irq_disable(priv);
> -		thermal_zone_device_unregister(priv->zone);
>  		if (rcar_use_of_thermal(dev))
>  			thermal_remove_hwmon_sysfs(priv->zone);
> +		else
> +			thermal_zone_device_unregister(priv->zone);
>  	}
>  
>  	pm_runtime_put(dev);