linux-kernel - Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2016 17:51:06 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Axel Lin <axel.lin@...ics.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, Alban Bedel <albeu@...e.fr>
Subject: Re: [PATCH 01/10] reset: ath79: add driver Kconfig option

On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
>  if RESET_CONTROLLER
>  
> +config RESET_ATH79
> +       bool "AR71xx Reset Driver" if COMPILE_TEST
> +       default ATH79
> +       help
> +         This enables the ATH79 reset controller driver that supports the
> +         AR71xx SoC reset controller.
> +
> 

Nice series!

Just note that there is one possible problem with COMPILE_TEST
when the platforms are enabled, as you can then disable a driver
that is normally there, and that can in turn cause problems in
rare cases, e.g. when the driver has a global function that is
called from platform code. I don't know if any of the drivers
do that, but if they do, you'd have to use

config RESET_ATH79
       bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
       default ATH79

to ensure that it's impossible to disable the driver on platforms
that require it.

	Arnd