linux-kernel - Re: [PATCH v2 3/7] staging: comedi: jr3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2016 18:35:51 -0400
From:   Anson Jacob <ansonjacob.aj@...il.com>
To:     Andrey Utkin <andrey_utkin@...tmail.com>
Cc:     gregkh@...uxfoundation.org, abbotti@....co.uk,
        hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning

On Sat, Aug 27, 2016 at 12:23:58AM +0300, Andrey Utkin wrote:
> On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote:
> >  
> > -	/* Default_FS contains the full scale that is used if the user does */
> > -	/* not set a full scale. */
> > +	/* 
> 
> Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning
> .git/rebase-apply/patch:226: trailing whitespace.
>         /* 
> warning: 1 line adds whitespace errors.
> 
> This means you have a space after asterisk. You would catch this if you run
> checkpatch.pl after making your commits.
> 
> Actually, some files you have amended, still have issues of same difficulty.
> You are encouraged to sort that out, too. See
> 
> for x in drivers/staging/comedi/drivers/cb_pcidas64.c drivers/staging/comedi/drivers/jr3_pci.c drivers/staging/comedi/drivers/jr3_pci.h drivers/staging/comedi/drivers/ni_at_a2150.c drivers/staging/comedi/drivers/ni_atmio.c drivers/staging/comedi/drivers/s626.h; do ./scripts/checkpatch.pl --strict -f $x; done

Thank you for the comments and the code snippet.

I only found one trailing whitespace issue in the patchset.

I will be uploading a new patchset with the fix for the trailing whitespace.

Are my commits are too long. Am I supposed to submit shorter ones.