linux-kernel - Re: [PATCH] fix:memory:of_memory:add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Aug 2016 19:54:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     dan.carpenter@...cle.com, linux-kernel@...r.kernel.org,
        arnd@...aro.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] fix:memory:of_memory:add missing header dependencies

On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:

Why would you do that?

> drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
> drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in drivers/memory/of_memory.h
> so this patch add missing header dependencies.

Why am I not seeing this warning on a "normal" build?  If there's no
prototype of a function, that seems odd...  What about sparse, does that
give you the same error here?

thanks,

greg k-h