linux-kernel - Re: [PATCH 3/6] rtl8188eu: declare internal function as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 Aug 2016 17:07:32 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        devel@...verdev.osuosl.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Geliang Tang <geliangtang@....com>,
        Jakub Sitnicki <jsitnicki@...il.com>,
        Ivan Safonov <insafonov@...il.com>,
        Kyle Kuffermann <kyle.kuffermann@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] rtl8188eu: declare internal function as static

Dear Andy,

thanks for your review.

On 28/08/2016 14:28, Andy Shevchenko wrote:
> On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:
> 
> Put here few words _why_ you are doing this.

I'm doing it because this function is only used inside rtw_recv.c. Which
is quite logical, since it's a timer callback: it is passed as the _fn
argument to setup_timer().

Sorry for not having explained this in my original commit.

I suppose now the best thing is to wait for a few days for more
comments, then resubmit with these changes. Do you think it is?

> Perhaps, add output of sparse static analyzer.

sparse does not detect this issue, and I don't think it could. I found
it by code inspection while working on other patches of this series.

-- 
Luca