linux-kernel - [PATCH] memstick: r592: add missing declaration in r592.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 28 Aug 2016 14:19:37 +0800
From:   Baoyou Xie <baoyou.xie@...aro.org>
To:     maximlevitsky@...il.com
Cc:     linux-kernel@...r.kernel.org, arnd@...aro.org,
        baoyou.xie@...aro.org, xie.baoyou@....com.cn
Subject: [PATCH] memstick: r592: add missing declaration in r592.h

We get 1 warning when build kernel with W=1:
drivers/memstick/host/r592.c:50:13: warning: no previous prototype for 'memstick_debug_get_tpc_name' [-Wmissing-prototypes]

in fact, function memstick_debug_get_tpc_name is implemented in r592.c
and exported but need to be declared in header file.

so this patch add its declaration in r592.h

in addition, this function don't check if the parameter tpc is valid, 
it will cause a panic and incur attack. 
but this need another patch to fix it.

Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
---
 drivers/memstick/host/r592.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/memstick/host/r592.h b/drivers/memstick/host/r592.h
index c5726c1..8f69fc1 100644
--- a/drivers/memstick/host/r592.h
+++ b/drivers/memstick/host/r592.h
@@ -172,4 +172,5 @@ struct r592_device {
 #define dbg_verbose(format, ...)	__dbg(2, format, ## __VA_ARGS__)
 #define dbg_reg(format, ...)		__dbg(3, format, ## __VA_ARGS__)
 
+const char *memstick_debug_get_tpc_name(int tpc);
 #endif
-- 
2.7.4