linux-kernel - Re: [PATCH] thermal: hisilicon: fix COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 10:25:10 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Eduardo Valentin <edubezval@...il.com>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: hisilicon: fix COMPILE_TEST dependencies

On Mon, Aug 29, 2016 at 10:00:52AM +0800, Zhang Rui wrote:
> On 五, 2016-08-26 at 17:44 +0200, Arnd Bergmann wrote:
> > As we now 'select STUB_CLK_HI6220', all dependencies for that driver
> > have
> > to be present in order to enable HISI_THERMAL, as pointed out by
> > Kconfig:
> > 
> > warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet
> > direct dependencies (COMMON_CLK && COMMON_CLK_HI6220 && MAILBOX)
> > 
> > This rearranges the dependencies for this symbol, so all the
> > dependencies
> > aside from ARCH_HISI are always met when building it for compile
> > testing.
> > This mainly helps for randconfig testing, as an "allmodconfig" kernel
> > will
> > enable them anyway.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 5f63581ce68e ("thermal: hisilicon: Add dependency on the clock
> > driver to allow frequency scaling")
> 
> As commit 5f63581ce68e has not been shipped in upstream yet, please
> fold this patch into the original one. I'd prefer one good patch
> instead of a broken patch + a fix.

Amit has one discussion with me, we have a more clear method to enable
Hisilicon thermal driver [1]: we are planning to enable
CONFIG_CPU_THERMAL in defconfig, and enable stub clock driver and
thermal driver depend on ARCH_HISI; so can resolve all dependency
issue.

I will prepare related patches and send out review ASAP, sorry for my
late.

[1] https://lkml.org/lkml/2016/8/8/879

Thanks,
Leo Yan

> > ---
> >  drivers/thermal/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 5cba072c3a62..3c8607c07352 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -177,7 +177,8 @@ config THERMAL_EMULATION
> >  
> >  config HISI_THERMAL
> >  	tristate "Hisilicon thermal driver"
> > -	depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
> > +	depends on ARCH_HISI || COMPILE_TEST
> > +	depends on CPU_THERMAL && OF && COMMON_CLK_HI6220 && MAILBOX
> >  	depends on HAS_IOMEM
> >  	select STUB_CLK_HI6220
> >  	help