linux-kernel - Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 01:28:13 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        rtc-linux@...glegroups.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        matthew.garrett@...ula.com
Subject: Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

Hi,

On 25/08/2016 at 16:54:18 +0200, Gabriele Mazzotta wrote :
> Hi,
> 
> were you able to verify that no other driver is affect?
> 

I had a closer look at the issue. I think what is happening is that you
don't enter the do/while loop in cmos_resume twice. That is supposed to
handle then clear the RTC_AIE bit and that is why the alarm still seems
enabled.

Can you add some tracing there to understand why? It is probably also
useful to know the value of cmos->suspend_ctrl in cmos_suspend.

My guess is that is_intr(mask) is false and you break out of the loop at
the first pass, meaning that the RTC_AIE bit is never cleared from
RTC_CONTROL. That would also mean that your RTC is not setting RTC_AF
after waking your PC. Am I right?

Regards,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com