linux-kernel - Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2016 15:25:22 +0800
From:   Kai Heng Feng <kai.heng.feng@...onical.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     alsa-devel@...a-project.org, Hui Wang <hui.wang@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda - Enable subwoofer on Dell Inspiron 7559

On Tue, Aug 30, 2016 at 3:05 PM, Takashi Iwai <tiwai@...e.de> wrote:
> On Tue, 30 Aug 2016 08:25:18 +0200,
> Kai Heng Feng wrote:
>>
>> On Tue, Aug 30, 2016 at 1:33 PM, Takashi Iwai <tiwai@...e.de> wrote:
>> > On Tue, 30 Aug 2016 07:27:41 +0200,
>> > Kai-Heng Feng wrote:
>> >>
>> >> The subwoofer on Inspiron 7559 does not work originally.
>> >> Applying a pin fixup can make it work.
>> >>
>> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> >> ---
>> >>  sound/pci/hda/patch_realtek.c | 11 +++++++++++
>> >>  1 file changed, 11 insertions(+)
>> >>
>> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> >> index 7100f05..2a3dd18 100644
>> >> --- a/sound/pci/hda/patch_realtek.c
>> >> +++ b/sound/pci/hda/patch_realtek.c
>> >> @@ -4855,6 +4855,7 @@ enum {
>> >>       ALC221_FIXUP_HP_FRONT_MIC,
>> >>       ALC292_FIXUP_TPT460,
>> >>       ALC298_FIXUP_SPK_VOLUME,
>> >> +     ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER,
>> >>  };
>> >>
>> >>  static const struct hda_fixup alc269_fixups[] = {
>> >> @@ -5516,6 +5517,15 @@ static const struct hda_fixup alc269_fixups[] = {
>> >>               .chained = true,
>> >>               .chain_id = ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
>> >>       },
>> >> +     [ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER] = {
>> >> +             .type = HDA_FIXUP_PINS,
>> >> +             .v.pins = (const struct hda_pintbl[]) {
>> >> +                     { 0x1b, 0x90170151 },
>> >
>> > What's the original value of this pin?
>> >
>> >
>> > Takashi
>>
>> The original value of 0x1b is 0x411111f0.
>
> OK, so it was disabled.  Maybe better to mention it in the patch
> description.
>
>
> Takashi

OK, I'll resend one with better description. Thanks for the advice.