linux-kernel - Re: [PATCH v3] memory-hotplug: fix store_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Sep 2016 13:37:17 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Reza Arbab <arbab@...ux.vnet.ibm.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Yaowei Bai <baiyaowei@...s.chinamobile.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Dan Williams <dan.j.williams@...el.com>,
        Xishi Qiu <qiuxishi@...wei.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Chen Yucong <slaoub@...il.com>,
        Andrew Banman <abanman@....com>,
        Seth Jennings <sjenning@...hat.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] memory-hotplug: fix store_mem_state() return value

On Thu,  1 Sep 2016 10:29:37 -0500 Reza Arbab <arbab@...ux.vnet.ibm.com> wrote:

> If store_mem_state() is called to online memory which is already online,
> it will return 1, the value it got from device_online().
> 
> This is wrong because store_mem_state() is a device_attribute .store
> function. Thus a non-negative return value represents input bytes read.
> 
> Set the return value to -EINVAL in this case.
> 

I actually made the mistake of reading this code.

What the heck are the return value semantics of bus_type.online? 
Sometimes 0, sometimes 1 and apparently sometimes -Efoo values.  What
are these things trying to tell the caller and why is "1" ever useful
and why doesn't anyone document anything.  grr.

And now I don't understand this patch.  Because:

static int memory_subsys_online(struct device *dev)
{
	struct memory_block *mem = to_memory_block(dev);
	int ret;

	if (mem->state == MEM_ONLINE)
		return 0;

Doesn't that "return 0" contradict the changelog?

Also, is store_mem_state() the correct place to fix this?  Instead,
should memory_block_change_state() detect an attempt to online
already-online memory and itself return -EINVAL, and permit that to be
propagated back?  Well, that depends on the bus_type.online rules which
appear to be undocumented.  What is the bus implementation supposed to
do when a request is made to online an already-online device?