linux-kernel - Re: [PATCH] relay: Use irq_work instead of plain timer for deferred wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Sep 2016 18:49:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     akash.goel@...el.com
Cc:     kbuild-all@...org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Tom Zanussi <tzanussi@...il.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Akash Goel <akash.goel@...el.com>
Subject: Re: [PATCH] relay: Use irq_work instead of plain timer for deferred
 wakeup

Hi Peter,

[auto build test WARNING on next-20160825]
[cannot apply to linus/master linux/master v4.8-rc4 v4.8-rc3 v4.8-rc2 v4.8-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/akash-goel-intel-com/relay-Use-irq_work-instead-of-plain-timer-for-deferred-wakeup/20160902-165512
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   lib/crc32.c:148: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:148: warning: Excess function parameter 'tab' description in 'crc32_le_generic'
   lib/crc32.c:293: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:293: warning: Excess function parameter 'tab' description in 'crc32_be_generic'
   lib/crc32.c:1: warning: no structured comments found
>> kernel/relay.c:336: warning: No description found for parameter 'work'
>> kernel/relay.c:336: warning: Excess function parameter 'data' description in 'wakeup_readers'
>> kernel/relay.c:336: warning: No description found for parameter 'work'
>> kernel/relay.c:336: warning: Excess function parameter 'data' description in 'wakeup_readers'

vim +/work +336 kernel/relay.c

b86ff981a Jens Axboe     2006-03-23  320  /* relay channel default callbacks */
b86ff981a Jens Axboe     2006-03-23  321  static struct rchan_callbacks default_channel_callbacks = {
b86ff981a Jens Axboe     2006-03-23  322  	.subbuf_start = subbuf_start_default_callback,
b86ff981a Jens Axboe     2006-03-23  323  	.buf_mapped = buf_mapped_default_callback,
b86ff981a Jens Axboe     2006-03-23  324  	.buf_unmapped = buf_unmapped_default_callback,
b86ff981a Jens Axboe     2006-03-23  325  	.create_buf_file = create_buf_file_default_callback,
b86ff981a Jens Axboe     2006-03-23  326  	.remove_buf_file = remove_buf_file_default_callback,
b86ff981a Jens Axboe     2006-03-23  327  };
b86ff981a Jens Axboe     2006-03-23  328  
b86ff981a Jens Axboe     2006-03-23  329  /**
b86ff981a Jens Axboe     2006-03-23  330   *	wakeup_readers - wake up readers waiting on a channel
9a9136e27 Linus Torvalds 2007-05-09  331   *	@data: contains the channel buffer
b86ff981a Jens Axboe     2006-03-23  332   *
60538b154 Peter Zijlstra 2016-09-02  333   *	This is the function used to defer reader waking
b86ff981a Jens Axboe     2006-03-23  334   */
60538b154 Peter Zijlstra 2016-09-02  335  static void wakeup_readers(struct irq_work *work)
b86ff981a Jens Axboe     2006-03-23 @336  {
60538b154 Peter Zijlstra 2016-09-02  337  	struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
b86ff981a Jens Axboe     2006-03-23  338  	wake_up_interruptible(&buf->read_wait);
b86ff981a Jens Axboe     2006-03-23  339  }
b86ff981a Jens Axboe     2006-03-23  340  
b86ff981a Jens Axboe     2006-03-23  341  /**
b86ff981a Jens Axboe     2006-03-23  342   *	__relay_reset - reset a channel buffer
b86ff981a Jens Axboe     2006-03-23  343   *	@buf: the channel buffer
b86ff981a Jens Axboe     2006-03-23  344   *	@init: 1 if this is a first-time initialization

:::::: The code at line 336 was first introduced by commit
:::::: b86ff981a8252d83d6a7719ae09f3a05307e3592 [PATCH] relay: migrate from relayfs to a generic relay API

:::::: TO: Jens Axboe <axboe@...e.de>
:::::: CC: Jens Axboe <axboe@...e.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6443 bytes)