linux-kernel - Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Sep 2016 21:04:29 +0800
From:   Louie Lu <louie.lu@...ebaytech.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Larry.Finger@...inger.net,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Amitoj Kaur Chawla <amitoj1606@...il.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        punit vara <punitvara@...il.com>,
        Parth Sane <laerdevstudios@...il.com>,
        Shivani Bhardwaj <shivanib134@...il.com>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

2016-09-02 20:55 GMT+08:00 Greg KH <gregkh@...uxfoundation.org>:
> On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
>> fixed comment style and space indent report from checkpatch:
>>
>> * WARNING: Statements should start on a tabstop
>> * WARNING: Block comments use * on subsequent lines
>> * WARNING: suspect code indent for conditional statements (16, 32)
>>
>> Signed-off-by: Louie Lu <louie.lu@...ebaytech.com>
>> ---
>>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
>>  1 file changed, 22 insertions(+), 15 deletions(-)
>
> This patch adds errors :(
>
> Now if you want to constantly submit new checkpatch cleanups to the
> driver, that's a good thing, but really, please use checkpatch on your
> patches to ensure you are doing things properly.
>
> I'm dropping it from my patch queue.
>
> thanks,
>
> greg k-h

Hi Greg,

sorry about that I didn't know I add error to this file.
I'll make sure this won't happen again.

And if I want to resubmit this patch 3/3, I'll only need to resend this one,
like [PATCH 3/3 v2] this way?

thanks,

Louie Lu