linux-kernel - Re: [v2] ErrHandling:Make IS_ERR_VALUE_U32 as generic API to avoid IS_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat,  3 Sep 2016 14:29:13 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     zajec5@...il.com, viresh.kumar@...aro.org,
        akpm@...ux-foundation.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, linville@...driver.com,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Subject: Re: [v2] ErrHandling:Make IS_ERR_VALUE_U32 as generic API to avoid
 IS_ERR_VALUE abuses.

Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an 'unsigned int' reflects an error.
> As they pass an 'unsigned int' into a function that takes an
> 'unsigned long' argument. This happens to work because the type
> is sign-extended on 64-bit architectures before it gets converted
> into an unsigned type.
> 
> However, anything that passes an 'unsigned short' or 'unsigned int'
> argument into IS_ERR_VALUE() is guaranteed to be broken, as are
> 8-bit integers and types that are wider than 'unsigned long'.
> 
> It would be nice to any users that are not passing 'unsigned int'
> arguments.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

This touches include/linux/err.h and I'm not very enthusiastic to change
anything in include directory without wider support. I recommend first to just
fix bcma.  And separately you can try to improve linux/err.h via some more
approariate tree, not via wireless trees.

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9222139/