linux-kernel - Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2016 16:42:48 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@...com>
Cc:     Peter Griffin <peter.griffin@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...inux.com, vinod.koul@...el.com, patrice.chotard@...com,
        dan.j.williams@...el.com, airlied@...ux.ie, kraxel@...hat.com,
        ohad@...ery.com, bjorn.andersson@...aro.org,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt
 nodes

On Mon, 05 Sep 2016, Arnaud Pouliquen wrote:
> >>>> +			dai-name = "Uni Reader #0 (PCM IN)";
> >>>
> >>> Oooo, not seen something like this before.
> >>>
> >>> If it does not already have one, it would require a DT Ack.
> >>
> >> No idea, the driver got merged 1 year ago.
> This field could be suppressed and handled in source code, using
> st,uniperiph-id to retreive it.

That would be better.

> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had  sent to Alsa mailing list only, I missed
> this obvious...

I'm surprised Mark didn't notice this.

He's usually pretty good at picking stuff like that up.

> >>>> +			st,version = <3>;
> >>>
> >>> This will likely need a DT Ack too.  We usually encode this sort of
> >>> information in the compatible string.
> yes, better to use compatibility
> >>
> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c
> > 
> > Well Rob's the boss.  We certainly never used to take 'device ID' or
> > 'version' attributes.  I guess something must have changed.
> 
> I will try to provide patches for code and bindings rework this week.

Wonderful.. Thanks Arnaud.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog