linux-kernel - Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 18:20:48 +0800
From:   Jisheng Zhang <jszhang@...vell.com>
To:     Mark Rutland <mark.rutland@....com>
CC:     <sebastian.hesselbarth@...il.com>, <robh+dt@...nel.org>,
        <catalin.marinas@....com>, <will.deacon@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to
 /soc node

Hi Mark,

On Tue, 6 Sep 2016 11:22:08 +0100 Mark Rutland wrote:

> On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
> > This patch fixes the following DTC warning with W=1:
> > 
> > "Node /soc has a reg or ranges property, but no unit name"
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@...vell.com>  
> 
> The node is only compatible with simple-bus, and so shouldn't have a
> reg.

IIUC, the warning is caused by "ranges = <0 0 0xf7000000 0x1000000>;"

Thanks,
Jisheng

> 
> Why not remove the reg?
> 
> Mark
> 
> > ---
> >  arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > index 099ad93..2d6f91f 100644
> > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> > @@ -134,7 +134,7 @@
> >  			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> >  	};
> >  
> > -	soc {
> > +	soc@...00000 {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -- 
> > 2.9.3
> >