linux-kernel - RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 12:19:36 +0000
From:   Khiem Nguyen <khiem.nguyen.xt@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Magnus Damm" <damm+renesas@...nsource.se>,
        Zhang Rui <rui.zhang@...el.com>,
        "Eduardo Valentin" <edubezval@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Thao Phuong Le. Nguyen" <thao.nguyen.yb@....renesas.com>,
        Hien Dang <hien.dang.eb@...esas.com>,
        "Toru Oishi" <toru.oishi.zj@...esas.com>,
        Khiem Nguyen <khiem.nguyen.xt@...esas.com>
Subject: RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal
 driver

Hi Geert,

Thanks for your comment.

> > +static int rcar_gen3_thermal_probe(struct platform_device *pdev) {
> 
> > +       priv->id = of_alias_get_id(dev->of_node, "tsc");
> > +       if (priv->id < 0) {
> > +               dev_err(dev, "Failed to get alias id (%d)\n", priv->id);
> > +               ret = priv->id;
> > +               goto error_unregister;
> > +       }
> 
> In v1, Morimoto-san wondered whether the alias is really needed, but you haven't
> addressed his question.
> 
> While aliases can be useful in DT source files, using aliases like this imposes
> hardcoded instance numbers, which is something we try to avoid these days.
> Also, this puts a hard requirement on the presence of the alias in DT, which should
> be documented in the DT bindings.

OK.
I prefer updating DT binding to describe alias.

There is requirement about coefficient to calculate temperature,
and the coefficient value (fixed value) is different among thermal sensors.

Thanks.

Best regards,
KHIEM Nguyen