linux-kernel - Re: [PATCH] ARM: mmp: replace NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 15:24:42 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Eric Miao <eric.y.miao@...il.com>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mmp: replace NO_IRQ

On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote:
> The mmp platform has its own definitions with the old NO_IRQ meaning,
> but compares against the global NO_IRQ macro that we should have
> removed long ago.
> 
> The specific usage in arch/arm/mach-mmp/devices.c is awkward, but
> fixing it properly would require a larger scale rewrite of the entire
> file, or even using devicetree for all machines. As I'm not able to
> do that any time soon, let's make the current behavior more explit
> instead and avoid the literal use of NO_IRQ.

So this probably continues to be a problem, but we hide it from the
NO_IRQ brigade.  I think it would be better to leave it as-is until
it can be fixed up correctly, rather than trying to hide it.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.