linux-kernel - Re: [RFC PATCH] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 12:43:28 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Neil Armstrong <narmstrong@...libre.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Wei Chen <Wei.Chen@....com>, Roland Stigge <stigge@...com.de>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [RFC PATCH] pinctrl: Add SX150X GPIO Extender Pinctrl Driver

On 2016-09-06 10:20, Neil Armstrong wrote:
> Hi Linus, Peter,
> 
> On 09/06/2016 08:44 AM, Peter Rosin wrote:
>> I intend to test this, but it might be a couple of days. I need
>> to bring the damn thing out of the closet and find the right
>> cables etc etc. And I of course have other stuff to do as well...
> 
> Is it a DT only platform you intent to test with ? In this case the current version is OK.

Yes, it's DT-only, but I don't expect it to be compatible as I linked
the wrong patch, see below...

*snip*

>> No, we have not, because we depend on yet to be upstreamed drivers
>> for all of our boards, sometimes written by us, sometimes from
>> the CPU vendor. For this driver, we were using a rejected patch
>> to configure the pins from DT in the gpio driver written by
>> Wei Chen [1] 
> 
> Actually it seems the patch was accepted, but it is not enough to handle
> DT completely since the gpio base is incorrect, this was the subject
> of my previous patch [2], make is DT compliant even for IRQ management.
> But having a pinctrl version seens far more reasonable.

Oh crap, wrong link... Here's a better one:
https://patchwork.kernel.org/patch/5437921/

>> One thing I noted at the very end of the patch was that I on
>> first glance did not see any i2c_del_driver call, maybe use the
>> module_i2c_driver macro?
> 
> Well, it's not present in the gpio version and since it manages IRQs, I assume it was
> decided to not use is as a module since it's needed to attach very early.

I just noted the omission, someone else will shirley know better than
me about what to do about it...

(BTW, we're not using interrupts)

Cheers,
Peter