linux-kernel - Re: [PATCH] dmaengine: cppi41: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2016 12:56:10 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: cppi41: mark PM functions as __maybe_unused

* Arnd Bergmann <arnd@...db.de> [160906 06:20]:
> When CONFIG_PM_SLEEP is disabled, we get a build error in
> the cppi41 dmaengine driver, since the runtime-pm functions
> are hidden within the wrong #ifdef:
> 
> drivers/dma/cppi41.c:1158:21: error: 'cppi41_runtime_suspend' undeclared here (not in a function)
> 
> This removes the #ifdef and instead uses __maybe_unused
> annotations that cannot have this problem.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")

Thanks for fixing it:

Acked-by: Tony Lindgren <tony@...mide.com>