linux-kernel - Re: [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2016 22:20:52 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:     Tomasz Figa <tomasz.figa@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Kukjin Kim <kgene@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values
 used for configuration

I have one comment though, if you're anyway making changes to all
the DTS files:

On Thu, Sep 1, 2016 at 9:23 AM, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:

> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;

Nowadays we have standard bindings for this, see
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt

Section "Generic pin multiplexing node content".

By patching the driver and bindings to accept also the standard
bindings with just function and pins and also adding support
for standard pin configurations like bias-disable
bias-pull-up with the old samsung,* bindings as a fallback
etc you can actually modernize the whole binding and
DTS looks to something simpler.

You will find that this is how newer platforms do it.

But it is admittedly a bigger project.

Yours,
Linus Walleij