linux-kernel - Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 09:46:45 +0200
From:   Richard Leitner <dev@...l1n.net>
To:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:     eric@...int.com, clemens.gruber@...ruber.com, tiwai@...e.com,
        perex@...ex.cz, broonie@...nel.org, lgirdwood@...il.com,
        Richard Leitner <dev@...l1n.net>
Subject: Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute
 controls

Hi,
any comments, updates or ideas for improvement on that patch?

regards,
Richard

On Wed, 31 Aug 2016 09:26:31 +0200
Richard Leitner <dev@...l1n.net> wrote:

> These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000
> using its CHIP_ANA_CTRL register.
> 
> Signed-off-by: Richard Leitner <dev@...l1n.net>
> ---
> CHANGES v2: fix invert value for both controls
> 	(sorry I've missed that in my initial tests!)
> ---
>  sound/soc/codecs/sgtl5000.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 527b759..a6af65d 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -411,6 +411,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
>  			0, 8,
>  			0x7f, 1,
>  			headphone_volume),
> +	SOC_SINGLE("Headphone Playback Switch", SGTL5000_CHIP_ANA_CTRL,
> +			4, 1, 1),
>  	SOC_SINGLE("Headphone Playback ZC Switch", SGTL5000_CHIP_ANA_CTRL,
>  			5, 1, 0),
>  
> @@ -423,6 +425,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
>  			SGTL5000_LINE_OUT_VOL_RIGHT_SHIFT,
>  			0x1f, 1,
>  			lineout_volume),
> +	SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
>  };
>  
>  /* mute the codec used by alsa core */