linux-kernel - RE: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 09:00:26 +0000
From:   "S.H. Xie" <shaohui.xie@....com>
To:     Marc Zyngier <marc.zyngier@....com>,
        "shh.xie@...il.com" <shh.xie@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Mihai Emilian Bantea <mihai.bantea@....com>,
        "C.H. Zhao" <chenhui.zhao@....com>,
        "arnd@...db.de" <arnd@...db.de>, "Z.Q. Hou" <zhiqiang.hou@....com>,
        "M.H. Lian" <minghuan.lian@....com>,
        Vincent Hu <mingkai.hu@....com>,
        Horia Geanta Neag <horia.geanta@....com>,
        "Q.Y. Gong" <qianyu.gong@....com>
Subject: RE: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support

> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_EDGE_RISING>,
> > +			     <GIC_PPI 14 IRQ_TYPE_EDGE_RISING>,
> > +			     <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>,
> > +			     <GIC_PPI 10 IRQ_TYPE_EDGE_RISING>;
> 
> No, this is completely wrong. The timer is always level triggered, and you're
> missing the affinity bits that are described the GIC binding.
[S.H] Will use (GIC_CPU_MASK_RAW(0xf) | IRQ_TYPE_LEVEL_LOW) in next version.

> 
> > +	};
> > +
> > +	pmu {
> > +		compatible = "arm,armv8-pmuv3";
> 
> Please add "arm,cortex-a72-pmu".
[S.H] Will use "arm,cortex-a72-pmu" in next version.

> 
> > +		interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> > +		interrupt-affinity = <&cpu0>,
> > +				     <&cpu1>,
> > +				     <&cpu2>,
> > +				     <&cpu3>;
> > +	};
> > +
> > +	gic: interrupt-controller@...0000 {
> > +		compatible = "arm,gic-400";
> > +		#interrupt-cells = <3>;
> > +		interrupt-controller;
> > +		reg = <0x0 0x1410000 0 0x10000>, /* GICD */
> > +		      <0x0 0x1420000 0 0x20000>, /* GICC */
> > +		      <0x0 0x1440000 0 0x20000>, /* GICH */
> > +		      <0x0 0x1460000 0 0x20000>; /* GICV */
> > +		interrupts = <1 9 0xf08>;
> 
> Please choose between expressing the interrupts entirely with numerals or entirely
> with symbols. At the moment this is a mix between the two.
[S.H] Will fix it in next version.

Thank you!

Shaohui