linux-kernel - Re: [PATCH v2 02/33] Documentation, ABI: Add a document entry for cache id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 10:11:56 -0500
From:   Nilay Vaish <nilayvaish@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        "H. Peter Anvin" <h.peter.anvin@...el.com>,
        Ingo Molnar <mingo@...e.hu>, Tony Luck <tony.luck@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Tejun Heo <tj@...nel.org>, Borislav Petkov <bp@...e.de>,
        Stephane Eranian <eranian@...gle.com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        Shaohua Li <shli@...com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        Vikas Shivappa <vikas.shivappa@...ux.intel.com>,
        Sai Prakhya <sai.praneeth.prakhya@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v2 02/33] Documentation, ABI: Add a document entry for
 cache id

On 8 September 2016 at 14:33, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Thu, 8 Sep 2016, Fenghua Yu wrote:
>> +What:                /sys/devices/system/cpu/cpu*/cache/index*/id
>> +Date:                July 2016
>> +Contact:     Linux kernel mailing list <linux-kernel@...r.kernel.org>
>> +Description: Cache id
>> +
>> +             The id identifies a hardware cache of the system within a given
>> +             cache index in a set of cache indices. The "index" name is
>> +             simply a nomenclature from CPUID's leaf 4 which enumerates all
>> +             caches on the system by referring to each one as a cache index.
>> +             The (cache index, cache id) pair is unique for the whole
>> +             system.
>> +
>> +             Currently id is implemented on x86. On other platforms, id is
>> +             not enabled yet.
>
> And it never will be available on anything else than x86 because there is
> no other architecture providing CPUID leaf 4 ....
>
> If you want this to be generic then get rid of the x86isms in the
> explanation and describe the x86 specific part seperately.
>

I second tglx here.  Also, I think this patch should be renumbered to
be patch 01/33.  The current 01/33 patch should be 02/33.  That way we
get to read about the definition of cache id first and its use comes
later.

--
Nilay