linux-kernel - Re: [PATCH v2] rtc: Add some dummy static inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 17:14:34 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Baolin Wang <baolin.wang@...aro.org>
cc:     a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com,
        rostedt@...dmis.org, mingo@...hat.com, john.stultz@...aro.org,
        broonie@...nel.org, linux-kernel@...r.kernel.org,
        rtc-linux@...glegroups.com
Subject: Re: [PATCH v2] rtc: Add some dummy static inline functions

On Thu, 8 Sep 2016, Baolin Wang wrote:

> The patch (commit id: a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021) adding
> tracepoints for alarmtimers will build failed on S390 platform, due to
> S390 defconfig did not define CONFIG_RTC_LIB macro to define the
> rtc_ktime_to_tm() function which is used in this patch. Thus we should
> add dummy static inline functions in case CONFIG_RTC_LIB is not defined.

I doubt this is a good idea. It will paper over usage of rtc lib functions
in generic code which will then lead to weird results on builds with
RTC_LIB=n.

Johns variant of making it conditional in the tracepoint is way safer.

Thanks

	tglx