[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 9 Sep 2016 16:18:40 +0100
From: Matt Fleming <matt@...eblueprint.co.uk>
To: Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
"H . Peter Anvin" <hpa@...or.com>
Cc: Markus Elfring <elfring@...rs.sourceforge.net>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
Matt Fleming <matt@...eblueprint.co.uk>,
Greg KH <gregkh@...uxfoundation.org>,
Julia Lawall <julia.lawall@...6.fr>,
Michel Lespinasse <walken@...gle.com>,
Mike Waychison <mikew@...gle.com>
Subject: [PATCH 18/29] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"
From: Markus Elfring <elfring@...rs.sourceforge.net>
The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Cc: Greg KH <gregkh@...uxfoundation.org>
Cc: Julia Lawall <julia.lawall@...6.fr>
Cc: Mike Waychison <mikew@...gle.com>
Cc: Michel Lespinasse <walken@...gle.com>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
---
drivers/firmware/google/gsmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index f1ab05ea56bb..c46387160976 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -910,8 +910,7 @@ out_err:
gsmi_buf_free(gsmi_dev.param_buf);
gsmi_buf_free(gsmi_dev.data_buf);
gsmi_buf_free(gsmi_dev.name_buf);
- if (gsmi_dev.dma_pool)
- dma_pool_destroy(gsmi_dev.dma_pool);
+ dma_pool_destroy(gsmi_dev.dma_pool);
platform_device_unregister(gsmi_dev.pdev);
pr_info("gsmi: failed to load: %d\n", ret);
return ret;
--
2.9.3
Powered by blists - more mailing lists