[<prev] [next>] [day] [month] [year] [list]
Date: Fri, 9 Sep 2016 16:56:38 +0100
From: Colin King <colin.king@...onical.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Nicholas Mc Guire <hofrat@...dl.org>,
devel@...verdev.osuosl.org
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] staging: ks7010: fix two memory leaks on error return path
From: Colin Ian King <colin.king@...onical.com>
On the error case where there is an invalid MAC address there is
memory leak on packet and pp on the error return. Free these first
before returning to fix the leak.
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
drivers/staging/ks7010/ks_hostif.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index c5fc31c..e09df360 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1196,6 +1196,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
DPRINTK(1, "ethernet->h_source=%02X:%02X:%02X:%02X:%02X:%02X\n",
eth->h_source[0], eth->h_source[1], eth->h_source[2],
eth->h_source[3], eth->h_source[4], eth->h_source[5]);
+ dev_kfree_skb(packet);
+ kfree(pp);
return -3;
}
--
2.9.3
Powered by blists - more mailing lists