linux-kernel - Re: [PATCH 1/2] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 17:57:24 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Jagan Teki <jagannadh.teki@...il.com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Matteo Lisi <matteo.lisi@...icam.com>,
        Michael Trimarchi <michael@...rulasolutions.com>
Subject: Re: [PATCH 1/2] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual
 initial support

On Fri, Sep 9, 2016 at 5:35 PM, Jagan Teki <jagannadh.teki@...il.com> wrote:

> +/dts-v1/;
> +
> +#include "imx6q.dtsi"
> +#include "imx6qdl-icore.dtsi"
> +
> +/ {
> +       model = "Engicam i.CoreM6 Quad/Dual Starter Kit";
> +       compatible = "fsl,imx6-icore", "fsl,imx6q";

Should be:
 compatible = "engicam,imx6-icore", "fsl,imx6q";

You could also send a patch adding engicam entry to
Documentation/devicetree/bindings/vendor-prefixes.txt

> +};
> +
> +&can1 {
> +       status = "oaky";

Should be "okay"

> +};
> +
> +&can2 {
> +       status = "oaky";

Should be "okay"

> +&iomuxc {
> +       pinctrl_flexcan1: flexcan1grp {
> +               fsl,pins = <
> +                       MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> +                       MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000

No 0x80000000, please. Use the real IOMUX register value instead.


> +               >;
> +       };
> +
> +       pinctrl_flexcan2: flexcan2grp {
> +               fsl,pins = <
> +                       MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x80000000
> +                       MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x80000000

Same here.