linux-kernel - Re: [PATCH] qede: mark qede_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 09 Sep 2016 18:16:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baoyou.xie@...aro.org
Cc:     Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
        everest-linux-l2@...gic.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH] qede: mark qede_set_features() static

From: Baoyou Xie <baoyou.xie@...aro.org>
Date: Thu,  8 Sep 2016 16:43:23 +0800

> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/qlogic/qede/qede_main.c:2113:5: warning: no previous prototype for 'qede_set_features' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Applied.