linux-kernel - Re: [PATCH 4/5] HID:hid-logitech: Rewrite of descriptor for all DF wheels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Sep 2016 09:34:24 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Simon Wood <gitsend@...gewell.org>
Cc:     kbuild-all@...org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
        Edwin Velds <edwin@...ds.nl>,
        Elias Vanderstuyft <elias.vds@...il.com>,
        Michal Maly <madcatxster@...il.com>,
        Simon Wood <simon@...gewell.org>
Subject: Re: [PATCH 4/5] HID:hid-logitech: Rewrite of descriptor for all DF
 wheels

Hi Simon,

[auto build test WARNING on hid/for-next]
[also build test WARNING on v4.8-rc5 next-20160909]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Simon-Wood/HID-hid-logitech-Introduce-dev_attr-for-combined-pedals-feature/20160910-065505
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: sh-titan_defconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

   drivers/hid/hid-lg.c: In function 'lg_report_fixup':
>> drivers/hid/hid-lg.c:347:28: warning: unused variable 'rev_min' [-Wunused-variable]
     __u16 bcdDevice, rev_maj, rev_min;
                               ^
>> drivers/hid/hid-lg.c:347:19: warning: unused variable 'rev_maj' [-Wunused-variable]
     __u16 bcdDevice, rev_maj, rev_min;
                      ^
>> drivers/hid/hid-lg.c:347:8: warning: unused variable 'bcdDevice' [-Wunused-variable]
     __u16 bcdDevice, rev_maj, rev_min;
           ^
>> drivers/hid/hid-lg.c:346:32: warning: unused variable 'udesc' [-Wunused-variable]
     struct usb_device_descriptor *udesc;
                                   ^

vim +/rev_min +347 drivers/hid/hid-lg.c

5f22a799 drivers/hid/hid-logitech.c Jiri Slaby         2008-05-16  340   * the original value of 0x28c of logical maximum to 0x104d
5f22a799 drivers/hid/hid-logitech.c Jiri Slaby         2008-05-16  341   */
73e4008d drivers/hid/hid-lg.c       Nikolai Kondrashov 2010-08-06  342  static __u8 *lg_report_fixup(struct hid_device *hdev, __u8 *rdesc,
73e4008d drivers/hid/hid-lg.c       Nikolai Kondrashov 2010-08-06  343  		unsigned int *rsize)
5f22a799 drivers/hid/hid-logitech.c Jiri Slaby         2008-05-16  344  {
25751553 drivers/hid/hid-lg.c       Axel Lin           2012-09-13  345  	struct lg_drv_data *drv_data = hid_get_drvdata(hdev);
54bfe3f0 drivers/hid/hid-lg.c       Paul Sbarra        2013-02-17 @346  	struct usb_device_descriptor *udesc;
54bfe3f0 drivers/hid/hid-lg.c       Paul Sbarra        2013-02-17 @347  	__u16 bcdDevice, rev_maj, rev_min;
5f22a799 drivers/hid/hid-logitech.c Jiri Slaby         2008-05-16  348  
4ab25786 drivers/hid/hid-lg.c       Jiri Kosina        2014-08-21  349  	if ((drv_data->quirks & LG_RDESC) && *rsize >= 91 && rdesc[83] == 0x26 &&
5f22a799 drivers/hid/hid-logitech.c Jiri Slaby         2008-05-16  350  			rdesc[84] == 0x8c && rdesc[85] == 0x02) {

:::::: The code at line 347 was first introduced by commit
:::::: 54bfe3f0dab2b2f0ac629690f187537d95adeb4f HID: logitech: add report descriptor for Driving Force wheel

:::::: TO: Paul Sbarra <sbarra.paul@...il.com>
:::::: CC: Jiri Kosina <jkosina@...e.cz>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (15776 bytes)