lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Sep 2016 08:17:13 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de> cc: linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org> Subject: Re: [PATCH] fs/dcache: resched/chill only if we make no progress On Thu, 8 Sep 2016, Sebastian Andrzej Siewior wrote: > + if (parent == dentry) { > + /* the task with the highest priority won't schedule */ > + r = cond_resched(); > + if (!r && (rt_task(current) || dl_task(current))) That's wrong because a non RT task will just spin until its time slice is up. Wasted cycles for nothing. Ideally we make spinning conditional on !on_cpu(dentry->lock->owner) That would avoid going to sleep if the owner runs on another cpu. We have no mechanism for that, but I think it'd be worth to think about one. > + cpu_chill(); > + } else > + dentry = parent; Missing braces Thanks, tglx
Powered by blists - more mailing lists