linux-kernel - Re: [PATCH v2] tpm: tpm_transmit() does not check for minimum buffer size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 23:16:06 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        "moderated list:TPM DEVICE DRIVER" 
        <tpmdd-devel@...ts.sourceforge.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tpm: tpm_transmit() does not check for minimum buffer
 size.

On Mon, Sep 12, 2016 at 11:32:19AM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 12, 2016 at 01:43:30PM +0300, Jarkko Sakkinen wrote:
> > tpm_transmit() does not check that bufsiz is at least TPM_HEADER_SIZE
> > before accessing data. This commit adds the check and returns -ENOMEM.
> 
> -EINVAL
> 
> > v2: Updated commit msg
> 
> After the diffstat, do not commit that to the tree

Duh, right. Thanks.

> Jason

/Jarkko