linux-kernel - Re: [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 11:16:24 +0930
From:   Joel Stanley <joel@....id.au>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request_irq

On Thu, Sep 8, 2016 at 11:28 PM, Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
> Save memory space and line of code by replacing setup_irq by request_irq.

Thanks. I also gave it a spin on our hardware to be sure.

> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

Acked-by: Joel Stanley <joel@....id.au>

> ---
>  drivers/clocksource/moxart_timer.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/moxart_timer.c b/drivers/clocksource/moxart_timer.c
> index ad2bead9..cba25b7 100644
> --- a/drivers/clocksource/moxart_timer.c
> +++ b/drivers/clocksource/moxart_timer.c
> @@ -79,7 +79,6 @@ struct moxart_timer {
>         unsigned int t1_enable_val;
>         unsigned int count_per_tick;
>         struct clock_event_device clkevt;
> -       struct irqaction act;
>  };
>
>  static inline struct moxart_timer *to_moxart(struct clock_event_device *evt)
> @@ -201,10 +200,6 @@ static int __init moxart_timer_init(struct device_node *node)
>         timer->clkevt.set_next_event = moxart_clkevt_next_event;
>         timer->clkevt.cpumask = cpumask_of(0);
>         timer->clkevt.irq = irq;
> -       timer->act.name = node->name;
> -       timer->act.flags = IRQF_TIMER;
> -       timer->act.handler = moxart_timer_interrupt;
> -       timer->act.dev_id = &timer->clkevt;
>
>         ret = clocksource_mmio_init(timer->base + TIMER2_BASE + REG_COUNT,
>                                     "moxart_timer", pclk, 200, 32,
> @@ -214,7 +209,8 @@ static int __init moxart_timer_init(struct device_node *node)
>                 return ret;
>         }
>
> -       ret = setup_irq(irq, &timer->act);
> +       ret = request_irq(irq, moxart_timer_interrupt, IRQF_TIMER,
> +                         node->name, &timer->clkevt);
>         if (ret) {
>                 pr_err("%s: setup_irq failed\n", node->full_name);
>                 return ret;
> --
> 1.9.1
>