linux-kernel - Re: [PATCH] USB: wusbcore: add in missing white space in error message text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 16:13:00 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: wusbcore: add in missing white space in error
 message text

On 9/12/2016 4:01 PM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> A dev_err message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/usb/wusbcore/cbaf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c
> index da1b872..62ade9f 100644
> --- a/drivers/usb/wusbcore/cbaf.c
> +++ b/drivers/usb/wusbcore/cbaf.c
> @@ -610,7 +610,7 @@ static int cbaf_probe(struct usb_interface *iface,
>  	cbaf->usb_iface = usb_get_intf(iface);
>  	result = cbaf_check(cbaf);
>  	if (result < 0) {
> -		dev_err(dev, "This device is not WUSB-CBAF compliant"
> +		dev_err(dev, "This device is not WUSB-CBAF compliant "
>  			"and is not supported yet.\n");

    The messages just shouldn't be broken up in order to facilitate grep'ping.

[...]

MBR, Sergei