linux-kernel - Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 15:35:05 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Bin Liu <b-liu@...com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared

* Bin Liu <b-liu@...com> [160908 11:26]:
> On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> >  config USB_MUSB_TUSB6010
> >  	tristate "TUSB6010"
> >  	depends on HAS_IOMEM
> > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> 
> Would this cause more issue later when trying to enable all glue drivers
> in one build?

Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
It completely redefines all the registers with ifdef else.

> The macros defined in tusb6010.h are only used in tusb6010.c, so how
> about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> instead? This gives flexibility to random config test, isn't it?

I'd like to see that but we have this in musb_core.c:

hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;

So the build would break there again on blackin with tusb6010..
Got any ideas on how to sort that out?

Regards,

Tony