linux-kernel - Re: [RFC][PATCH v1 1/2] libsas: Alloc dynamic work to avoid missing sas events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 13:52:55 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Yijing Wang <wangyijing@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     Tejun Heo <tj@...nel.org>, Qilin Chen <chenqilin2@...wei.com>,
        Wei Fang <fangwei1@...wei.com>,
        Yousong He <heyousong@...wei.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH v1 1/2] libsas: Alloc dynamic work to avoid missing
 sas events

On 09/13/2016 04:30 AM, Yijing Wang wrote:
> Now libsas hotplug work is static, LLDD driver queue
> the hotplug work into shost->work_q. If LLDD driver
> burst post lots hotplug event to libsas, the hotplug
> events may pending in the workqueue like
> 
> shost->workq
> tail | PHYE_LOSS_OF_SIGNAL  | PORTE_BYTES_DMAED | head
> 
> In this case, if a new PORTE_BYTES_DMAED event coming,
> it would be lost, because we can not queue a work which
> is already pending in the workqueue, also libsas has a
> pending bit to avoid queue the same event.
> 
> The lost hotplug event make something confusing, e.g.
> we have sas disks connected hardware, but we can not
> found them in kernel.
> 
> This patch remove the static defined hotplug work,
> and use dynamic work to avoid missing hotplug events.
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> Signed-off-by: Yousong He <heyousong@...wei.com>
> Signed-off-by: Qilin Chen <chenqilin2@...wei.com>
> ---
>  drivers/scsi/libsas/sas_event.c    |   61 ++++++++++++++++++++---------------
>  drivers/scsi/libsas/sas_init.c     |    5 +--
>  drivers/scsi/libsas/sas_internal.h |    3 ++
>  drivers/scsi/libsas/sas_phy.c      |   50 ++++++++---------------------
>  drivers/scsi/libsas/sas_port.c     |   23 ++++++++------
>  include/scsi/libsas.h              |    8 -----
>  6 files changed, 66 insertions(+), 84 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)