linux-kernel - Re: [PATCH] dmaengine: squash lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 19:07:34 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     dmaengine@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Peter Griffin <peter.griffin@...aro.org>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephen Warren <swarren@...dotorg.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Alexandre Courbot <gnurou@...il.com>,
        Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] dmaengine: squash lines for immediate return

On Tue, Sep 13, 2016 at 04:20:54AM +0900, Masahiro Yamada wrote:
> Remove unneeded variables and assignments.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/dma/cppi41.c          | 30 +++++-------------------------
>  drivers/dma/imx-sdma.c        | 15 ++++-----------
>  drivers/dma/ppc4xx/adma.c     | 15 ++++++---------
>  drivers/dma/tegra20-apb-dma.c |  4 +---

pls split per driver

>  static int cppi41_dma_alloc_chan_resources(struct dma_chan *chan)
> @@ -433,11 +429,7 @@ static u32 get_host_pd0(u32 length)
>  
>  static u32 get_host_pd1(struct cppi41_channel *c)
>  {
> -	u32 reg;
> -
> -	reg = 0;
> -
> -	return reg;
> +	return 0;
>  }

why to have this, can you fix the calling code...

>  
>  static u32 get_host_pd2(struct cppi41_channel *c)
> @@ -452,12 +444,8 @@ static u32 get_host_pd2(struct cppi41_channel *c)
>  
>  static u32 get_host_pd3(u32 length)
>  {
> -	u32 reg;
> -
>  	/* PD3 = packet size */
> -	reg = length;
> -
> -	return reg;
> +	return length;
>  }

so we are essentially returning back the arg, lets remove this as well
please

>  
>  static u32 get_host_pd6(u32 length)
> @@ -473,20 +461,12 @@ static u32 get_host_pd6(u32 length)
>  
>  static u32 get_host_pd4_or_7(u32 addr)
>  {
> -	u32 reg;
> -
> -	reg = addr;
> -
> -	return reg;
> +	return addr;
>  }

same here too

>  
>  static u32 get_host_pd5(void)
>  {
> -	u32 reg;
> -
> -	reg = 0;
> -
> -	return reg;
> +	return 0;
>  }

and this one too

-- 
~Vinod