linux-kernel - RE: [PATCH v5] lib/bitmap.c: enhance bitmap syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Sep 2016 06:52:38 +0000
From:   Noam Camus <noamca@...lanox.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "decot@...glers.com" <decot@...glers.com>,
        "ben@...adent.org.uk" <ben@...adent.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xinhui@...ux.vnet.ibm.com" <xinhui@...ux.vnet.ibm.com>
Subject: RE: [PATCH v5] lib/bitmap.c: enhance bitmap syntax

> From: Andrew Morton [mailto:akpm@...ux-foundation.org] 
> Sent: Wednesday, September 14, 2016 1:54 AM

>> diff --git a/Documentation/kernel-parameters.txt 
>> b/Documentation/kernel-parameters.txt
>> index 623502e..4f1e95b 100644
>> --- a/Documentation/kernel-parameters.txt
>> +++ b/Documentation/kernel-parameters.txt
>> @@ -33,6 +33,21 @@ can also be entered as  Double-quotes can be used 
>> to protect spaces in values, e.g.:
>>  	param="spaces in here"
>>  
>> +Some of the kernel parameters takes list of CPUs as value e.g.:
>> +isolcpus, task_isolation, nohz_full, irqaffinity, rcu_nocbs.

>I don't think we have a "task_isolation".  What are you trying to refer to here?
Sorry, my glitch, it is another parameter I use which is still not accepted to mainline. See this url:
https://lkml.kernel.org/g/1471382376-5443-1-git-send-email-cmetcalf@mellanox.com

>> +The format of this list is:
>> +<cpu number>,...,<cpu number>
>> +or
>> +<cpu number>-<cpu number>
>> +(must be a positive range in ascending order) or a mixture <cpu 
>> +number>,...,<cpu number>-<cpu number> Note that for special case of 
>> +range one can split range into equal size of groups and for each 
>> +group to use some amount form the begin of that group.
>> +<cpu number>-cpu number>:<used size>/<group size> For example one can 
>> +add to its command line following parameter:
>> +isolcpus=1,2,10-20,100-2000:2/25
>> +

>I think we can do better here.  Please review:
Thanks, I reviewed and it looks great.

- Noam